[libvirt] [PATCH] console: plug memory leaks
Alex Jia
ajia at redhat.com
Tue Dec 20 09:41:31 UTC 2011
On 12/20/2011 05:32 PM, ajia at redhat.com wrote:
> From: Alex Jia<ajia at redhat.com>
>
> Using 'virReallocN' to allocate memory on virConsoleEventOnStdin,
> virConsoleEventOnStdout and virConsoleEventOnStream, however, the
> cleanup function virConsoleShutdown hasn't released these memory.
>
> * tools/console.c: fix memory leaks on virConsoleShutdown.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=767488
>
> Signed-off-by: Alex Jia<ajia at redhat.com>
> ---
> tools/console.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/tools/console.c b/tools/console.c
> index e6118a0..86376e4 100644
> --- a/tools/console.c
> +++ b/tools/console.c
> @@ -101,6 +101,12 @@ virConsoleShutdown(virConsolePtr con)
> virStreamAbort(con->st);
> virStreamFree(con->st);
> }
> + if (con->streamToTerminal.data) {
> + VIR_FREE(con->streamToTerminal.data);
> + }
> + if (con->terminalToStream.data) {
> + VIR_FREE(con->terminalToStream.data);
> + }
'{}' are useless, will send a v2 to remove them.
> if (con->stdinWatch != -1)
> virEventRemoveHandle(con->stdinWatch);
> if (con->stdoutWatch != -1)
More information about the libvir-list
mailing list