[libvirt] [libvirt-glib] Correct namespace prefix for GVirConfig symbols

Christophe Fergeau cfergeau at redhat.com
Thu Dec 22 15:17:32 UTC 2011

On Thu, Dec 22, 2011 at 02:26:48AM +0200, Zeeshan Ali (Khattak) wrote:
> On Thu, Dec 22, 2011 at 1:46 AM, Zeeshan Ali (Khattak)
> <zeeshanak at gnome.org> wrote:
> > On Thu, Dec 22, 2011 at 1:43 AM, Zeeshan Ali (Khattak)
> > <zeeshanak at gnome.org> wrote:
> >> From: "Zeeshan Ali (Khattak)" <zeeshanak at gnome.org>
> >>
> >> Breaks API and ABI on the fundamental level but lets fix this now while
> >> we don't guarantee any API/ABI stability.
> >
> > Forgot to mention that this patch is on top of Christophe's ACK'ed but
> > unmerged 'Add GVirConfigDomainSound' tree.
>   And seems my patch went over the limit so it got chopped. You can
> find the patch here as well:
> https://gitorious.org/~zeenix/libvirt/zeenix-libvirt-glib/commit/d5e5c64732baa091d5078c87aab64df4cdb9e08d

For what it's worth, I don't think this patch improves the situation much
if we can't express nested namespaces (ie put all the GVirConfigDomain*
objects to a GVir::Config::Domain or GVirConfig::Domain namespace). Since
it's pretty invasive, I'd lean toward not applying it, but I have no strong
opinion either way, I'm fine if it goes in too. Let's see what danpb thinks
about it :)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20111222/deff14d7/attachment-0001.sig>

More information about the libvir-list mailing list