[libvirt] [PATCH 1/3] qemuBuildDeviceAddressStr() checks for QEMUD_CMD_FLAG_PCI_MULTIBUS

[Eric Blake]

On 02/01/2011 09:22 AM, Niels de Vos wrote:
> -        virBufferVSprintf(buf, ",bus=pci.0,addr=0x%x", info->addr.pci.slot);
> +        if (qemuCmdFlags & QEMUD_CMD_FLAG_PCI_MULTIBUS)
> +            virBufferVSprintf(buf, ",bus=pci.0,addr=0x%x", info->addr.pci.slot);
> +        else
> +            virBufferVSprintf(buf, ",bus=pci,addr=0x%x", info->addr.pci.slot);

I probably would have done:

virBufferVSprintf(buf, ",bus=pci%s,addr=0x%x",
                  qemuCmdFlags & QEMU_CMD_FLAG_PCI_MULTIBUS ? ".0", "",
                  info->addr.pci.slot);

to avoid the if/else, but that's not worth changing.

Agree with danpb's ack.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110202/26ef7a10/attachment-0001.sig>