[libvirt] [PATCH] macvtap.c: add parenthesis for similar expressions

Davidlohr Bueso dave at gnu.org
Thu Feb 3 18:12:32 UTC 2011


It wouldn't hurt to add some parenthesis in the following two similar expression for better readability.

---
 src/util/macvtap.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/util/macvtap.c b/src/util/macvtap.c
index 09d7b78..92147ab 100644
--- a/src/util/macvtap.c
+++ b/src/util/macvtap.c
@@ -1048,8 +1048,8 @@ doPortProfileOpSetLink(bool nltarget_kernel,
 
             memcpy(ifla_vf_mac.mac, macaddr, 6);
 
-            if (!nla_put(nl_msg, IFLA_VF_MAC, sizeof(ifla_vf_mac),
-                &ifla_vf_mac) < 0)
+            if ((!nla_put(nl_msg, IFLA_VF_MAC, sizeof(ifla_vf_mac), 
+                &ifla_vf_mac)) < 0)
                 goto buffer_too_small;
         }
 
@@ -1060,8 +1060,8 @@ doPortProfileOpSetLink(bool nltarget_kernel,
                 .qos = 0,
             };
 
-            if (!nla_put(nl_msg, IFLA_VF_VLAN, sizeof(ifla_vf_vlan),
-                &ifla_vf_vlan) < 0)
+            if ((!nla_put(nl_msg, IFLA_VF_VLAN, sizeof(ifla_vf_vlan),
+                &ifla_vf_vlan)) < 0)
                 goto buffer_too_small;
         }
 
-- 
1.7.1






More information about the libvir-list mailing list