[libvirt] [PATCHv5 0/9] smartcard round 5

Eric Blake eblake at redhat.com
Fri Feb 4 04:01:11 UTC 2011


Next round.  The first 5 patches were previously ack'd in round 4:
https://www.redhat.com/archives/libvir-list/2011-February/msg00026.html

However, I heavily rewrote patch 3 to support later spicevmc patches,
as well as tweaked patch 1 and 5 to avoid the need for memory rounding.

Patch 6 is mostly a port of a patch that has already seen use in RHEL
6.0 which adds the use of -chardev spicevmc,name=vdagent as a means of
communicating with the guest using messages across the main SPICE
graphics channel, but tweaked to be a bit more robust.

Patch 7 was an experiment to add a new vdagent channel type instead of
reusing virtio for the spicevmc channel; I think it failed, but wanted
to at least post it in case I was on the right track after all.  Patch
8 undoes 7.  It won't hurt my feelings if you skip those.

Patch 9 therefore immediately follows patch 6, and marries the two
concepts to create a smartcard passthrough device that uses a new
smartcard channel of the SPICE server.

Again, this entire series depends on a feature that has been proposed
for upstream qemu, but not accepted yet; while it has probably
stabilized to some degree, it may have minor tweaks.  Conversely,
I feel that the XML representation (the most important part to get
right, since it becomes our API contract) is accurate and flexible
enough to cover whatever minor modifiations qemu throws at us as
followup patches to qemu_command.c.

Daniel P. Berrange (1):
  spicevmc: support new qemu chardev

Eric Blake (8):
  smartcard: add XML support for <smartcard> device
  smartcard: add domain conf support
  smartcard: check for qemu capability
  smartcard: enable SELinux support
  smartcard: turn on qemu support
  RFC: spicevmc: call out vdagent as a channel target
  Revert "RFC: spicevmc: call out vdagent as a channel target"
  smartcard: add spicevmc support

 cfg.mk                                             |    1 +
 docs/formatdomain.html.in                          |  120 ++++++-
 docs/schemas/domain.rng                            |   70 ++++-
 src/conf/domain_conf.c                             |  395 +++++++++++++++++++-
 src/conf/domain_conf.h                             |   64 +++-
 src/libvirt_private.syms                           |    6 +
 src/qemu/qemu_capabilities.c                       |   17 +-
 src/qemu/qemu_capabilities.h                       |    3 +
 src/qemu/qemu_command.c                            |  154 +++++++-
 src/security/security_selinux.c                    |   76 ++++
 tests/qemuhelpdata/qemu-kvm-0.12.1.2-rhel61        |  229 +++++++++++
 tests/qemuhelpdata/qemu-kvm-0.12.1.2-rhel61-device |   74 ++++
 tests/qemuhelptest.c                               |   43 +++
 .../qemuxml2argv-channel-spicevmc.args             |    9 +
 .../qemuxml2argv-channel-spicevmc.xml              |   34 ++
 .../qemuxml2argv-smartcard-controller.args         |    7 +
 .../qemuxml2argv-smartcard-controller.xml          |   19 +
 .../qemuxml2argv-smartcard-host-certificates.args  |    8 +
 .../qemuxml2argv-smartcard-host-certificates.xml   |   20 +
 .../qemuxml2argv-smartcard-host.args               |    7 +
 .../qemuxml2argv-smartcard-host.xml                |   16 +
 ...emuxml2argv-smartcard-passthrough-spicevmc.args |    7 +
 ...qemuxml2argv-smartcard-passthrough-spicevmc.xml |   16 +
 .../qemuxml2argv-smartcard-passthrough-tcp.args    |    8 +
 .../qemuxml2argv-smartcard-passthrough-tcp.xml     |   19 +
 tests/qemuxml2argvtest.c                           |   20 +
 26 files changed, 1410 insertions(+), 32 deletions(-)
 create mode 100644 tests/qemuhelpdata/qemu-kvm-0.12.1.2-rhel61
 create mode 100644 tests/qemuhelpdata/qemu-kvm-0.12.1.2-rhel61-device
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-channel-spicevmc.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-channel-spicevmc.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-smartcard-controller.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-smartcard-controller.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-smartcard-host-certificates.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-smartcard-host-certificates.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-smartcard-host.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-smartcard-host.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-smartcard-passthrough-spicevmc.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-smartcard-passthrough-spicevmc.xml
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-smartcard-passthrough-tcp.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-smartcard-passthrough-tcp.xml

-- 
1.7.4




More information about the libvir-list mailing list