[libvirt] [PATCH] Only initialize/cleanup libpciaccess once

Eric Blake eblake at redhat.com
Mon Feb 7 17:14:04 UTC 2011


On 02/07/2011 10:05 AM, Daniel P. Berrange wrote:
> libpciaccess has many bugs in its pci_system_init/cleanup
> functions that makes calling them multiple times unwise.
> eg it will double close() FDs, and leak other FDs.
> 
> * src/node_device/node_device_udev.c: Only initialize
>   libpciaccess once
> ---
>  src/node_device/node_device_udev.c |   25 +++++++++++++------------
>  1 files changed, 13 insertions(+), 12 deletions(-)

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110207/dcf4dcbe/attachment-0001.sig>


More information about the libvir-list mailing list