[libvirt] [libvirt-snmp][PATCH v2] Remove the hard coded connection URI.
Daniel Veillard
veillard at redhat.com
Thu Feb 10 10:47:44 UTC 2011
On Thu, Feb 10, 2011 at 10:20:04AM +0000, Daniel P. Berrange wrote:
> On Thu, Feb 10, 2011 at 10:02:35AM +0100, Michal Privoznik wrote:
> > So now we rely on libvirt LIBVIRT_DEFAULT_URI environment variable.
> > ---
> > src/libvirtSnmp.c | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/src/libvirtSnmp.c b/src/libvirtSnmp.c
> > index ce21369..39b74bd 100644
> > --- a/src/libvirtSnmp.c
> > +++ b/src/libvirtSnmp.c
> > @@ -180,7 +180,8 @@ int libvirtSnmpInit(void)
> > /* virConnectOpenAuth is called here with all default parameters,
> > * except, possibly, the URI of the hypervisor. */
> > /* TODO: configure the URI */
> > - conn = virConnectOpenAuth("qemu:///system", virConnectAuthPtrDefault, 0);
> > + /* Use libvirt env variable LIBVIRT_DEFAULT_URI by default*/
> > + conn = virConnectOpenAuth("", virConnectAuthPtrDefault, 0);
>
> It needs to be NULL, rather than "".
ACK for a version with NULL :-)
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel at veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/
More information about the libvir-list
mailing list