[libvirt] [PATCH] conf: Fix XMl generation for smartcards
Eric Blake
eblake at redhat.com
Mon Feb 14 16:31:49 UTC 2011
On 02/14/2011 04:18 AM, Jiri Denemark wrote:
> When formating XML for smartcard device with mode=host, libvirt
s/formating/formatting/
> generates invalid XML if the device has address info associated:
>
> <smartcard mode='host' <address type='ccid' controller='0' slot='1'/>
> ---
> src/conf/domain_conf.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 59adf36..f2bb3aa 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -7058,6 +7058,7 @@ virDomainSmartcardDefFormat(virBufferPtr buf,
> virBufferAddLit(buf, "/>\n");
> return 0;
> }
> + virBufferAddLit(buf, ">\n");
> break;
ACK; thanks for catching this. Definitely a pre-0.8.8 bug fix.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110214/2ae8734f/attachment-0001.sig>
More information about the libvir-list
mailing list