[libvirt] [PATCH] virDomainMemoryStats: avoid null dereference

[Eric Blake]

On 02/14/2011 05:38 PM, Laine Stump wrote:
> On 02/14/2011 06:25 PM, Eric Blake wrote:
>> * src/libvirt.c (virDomainMemoryStats): Check domain before flags.
>> ---
>>
>> Another valid bug found by clang.  User's generally should't call
>> virDomainMemoryStats(NULL,...), but we don't forbid it elsewhere, and
>> doing so is not supposed to crash libvirt.  All other flags checks in
>> this file occur after validating the object first.
> 
> ACK

Thanks; pushed.

Wow - that actually caused a SHA1 hash collision in git that requires 8
hex digits to resolve (compared to the usual 7 or less)!

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110215/5c0241b6/attachment-0001.sig>