[libvirt] [PATCH] build: address clang reports about virCommand

[Eric Blake]

On 02/15/2011 10:41 AM, Laine Stump wrote:
> On 02/14/2011 05:30 PM, Eric Blake wrote:
>> clang had 5 reports against virCommand; three were false positives
>> (a NULL deref in ProcessIO solved by sa_assert, and two uninitialized
>> memory operations solved by adding an initializer), but two were real.
>>
>> * src/util/command.c (virCommandProcessIO): Fix real bug of
>> possible NULL dereference.  Teach clang that buf is never NULL.
>> (virCommandRun): Teach clang that infd is only ever accessed when
>> initialized.
>> ---
>>   src/util/command.c |   10 ++++++----
>>   1 files changed, 6 insertions(+), 4 deletions(-)

> 
> ACK

Thanks; pushed.

As a wrap-up to my clang session yesterday, there were also some false
positives in gnulib's vasnprintf implementation; discussion on the
gnulib list is considering using the name assume() or invariant()
instead of sa_assert() - but I doubt that it will happen before
libvirt-0.8.8, so we can worry about adjusting to any gnulib changes at
a later date.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110215/dd97e47a/attachment-0001.sig>