[libvirt] [PATCH v2] qemu: Error prompt when saving a shutoff domain
Eric Blake
eblake at redhat.com
Wed Feb 16 16:22:32 UTC 2011
On 02/16/2011 03:06 AM, Osier Yang wrote:
> "qemudDomainSaveFlag" goto wrong label "endjob", which will cause
> error when security manager trying to restore label (regression).
>
> As it's more reasonable to check if vm is shutoff immediately, and
> return right away if it is, remove the checking in "qemudDomainSaveFlag",
> and add checking in "qemudDomainSave".
>
> * src/qemu/qemu_driver.c
> ---
> src/qemu/qemu_driver.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
ACK. The only other caller of qemudDomainSaveFlag is
qemuDomainManagedSave, and it also checks that vm is active before
calling the helper.
One nit: can you adjust the comment before qemudDomainSaveFlag to
document that vm must be active (it already documents that it is a
helper to be run while the lock is held).
Worth applying before 0.8.8.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110216/77098cad/attachment-0001.sig>
More information about the libvir-list
mailing list