[libvirt] [PATCH] Drop empty argument from dnsmasq call

[Laine Stump]

On 02/18/2011 01:32 PM, Eric Blake wrote:
> On 02/18/2011 07:37 AM, Guido Günther wrote:
>> Hi,
>> Libvirt currently fails to start with dnsmasq>= 2.56.
>> since dnsmasq now bails out with empty arguments. See
>>
>> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=613944
>>
>> for the Debian bug and
>>
>> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=589885
>>
>> for the upstream reasoning.
>>
>> Tested with 2.55 and 2.56. O.k. to apply?
>> Cheers,
>>   -- Guido
> I was worried that this might cause a regression with older dnsmasq,
> given the previous conversation on this topic:
> https://www.redhat.com/archives/libvir-list/2010-December/msg00504.html

I had a similar email composed, including the same reference, but was 
going about investigating RHEL5 compatibility in a different way - 
building libvirt with this change on RHEL5 and seeing what happens (what 
I should have done when I first encountered it, rather than sweeping it 
under the rug). Since my RHEL5 installation was in a state of disrepair, 
you beat me to the punch :-)

Basically my thinking is similar to yours, though. RHEL5's dnsmasq is 
probably the oldest that we need to worry about supporting, so if having 
the empty arg there breaks something new, and removing it doesn't break 
RHEL5's dnsmasq, then I'm happy to see it go.