[libvirt] [TCK] [PATCH] follow reordering of match extensions relative to state match

[Stefan Berger]

On 02/18/2011 10:12 AM, Eric Blake wrote:
> On 02/18/2011 08:04 AM, Stefan Berger wrote:
>> On 02/14/2011 02:09 PM, Stefan Berger wrote:
>>> On 02/14/2011 11:44 AM, Eric Blake wrote:
>>>> On 02/14/2011 08:09 AM, Stefan Berger wrote:
>>>>> This patch adjusts the tck test cases following the reordering of the
>>>>> match extensions relative to the state match in libvirt.
>>>>>
>>>>> -RETURN     udp  --  0.0.0.0/0            10.1.2.3            MAC
>>>>> 01:02:03:04:05:06 DSCP match 0x22/* udp rule */ udp spts:291:400
>>>> Here, there's a space between 0x22 and udp, after you strip the comment.
>>>>
>>> This is all iptables output and seems to be a problem of iptables
>>> sometimes omitting spaces. It looks like a comment rule automatically
>>> adds a space after it ...
>>>>> dpts:564:1092 state NEW,ESTABLISHED ctdir REPLY
>>>>> +RETURN     udp  --  0.0.0.0/0            10.1.2.3            MAC
>>>>> 01:02:03:04:05:06 DSCP match 0x22udp spts:291:400 dpts:564:1092 state
>>>> But that space is lost here.  Does the libvirt side of the patch need
>>>> fixing?
>>>>
>>> ... while the DSCP match 0x22 forgets to add a space. This is not a
>>> libvirt problem.
>>>
>>>      Stefan
>>>
>> ACK?
> Yes; it matches the latest libvirt release, and as you say, the output
> issues is an iptables bug (have you reported it there?).  ACK.
>
I'll push and file a bugzilla with iptables.

    Stefan