[libvirt] [PATCH] virsh: Make <mac> required when device-detaching interface

[Osier Yang]

于 2011年02月23日 12:30, Daniel Veillard 写道:
> On Tue, Feb 22, 2011 at 11:16:29AM +0100, Michal Privoznik wrote:
>> Problem is, if user does not specify mac address in input XML,
>> we generate a random one, which is why device-detach fails giving
>> a confusing error message. Therefore<mac>  needs to be required.
>
>    Well if the domain only has one interface then if there is no<mac>
> specified the semantic of the operation is still clear. Since it a very
> frequent user case, I would rather not break something which was working
> and has a clear semantic.
>
>    IMHO we should check if the domain has multiple interface first and
> only raise a problem then. I think I saw such a patch a few weeks ago
> possibly in a different context though.
>

I guess you mean this one, :-)

https://www.redhat.com/archives/libvir-list/2011-January/msg01011.html

Regards
Osier