[libvirt] [PATCH] vmx: Add support for video device VRAM size

[Eric Blake]

On 12/30/2010 10:14 AM, Matthias Bolte wrote:
> Update test suite accordingly.

> +
> +    virBufferVSprintf(buffer, "svga.vramSize = \"%d\"\n",
> +                      def->vram * 1024); /* Scale from kilobytes to bytes */

Should this be %lld, def->vram * 1024ll, to avoid overflow concerns?

Otherwise, it looks okay to me.  Conditional ACK based on the answer to
that question.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110104/33de5f96/attachment-0001.sig>