[libvirt] Bug in virsh memtune on RHEL6?

[Eric Blake]

On 01/06/2011 08:29 AM, Justin Clift wrote:
> Hi all,
> 
> Getting strange numbers from the virsh memtune command on
> RHEL 6.  (git head compiled, rather than RHEL 6 packages)
> 
>   virsh # list
>    Id Name                 State
>   ----------------------------------
>     4 Fedora_14_x64        running
> 
>   virsh # memtune Fedora_14_x64
>   hard_limit     : 9007199254740991
>   soft_limit     : 9007199254740991
>   swap_hard_limit: 9007199254740991
> 
> Those numbers are supposed to be kilobytes, but the host
> box itself only has 12GB ram.
> 
> Bug?

Smells like a case of mistakenly treating either -1 or INT64_MAX as a
valid value (that integer is 0x1f_ffff_ffff_ffff, which happens to be
UINT64_MAX>>11 or INT64_MAX>>10), rather than recognizing it as meaning
unlimited or undeterminable.  If unlimited is the intended meaning,
virsh can probably be taught to display it differently, perhaps by also
referencing the host's limits.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110106/95afdb3a/attachment-0001.sig>