[libvirt] [PATCH] Fix error reporting when machine type probe fails

Daniel P. Berrange berrange at redhat.com
Tue Jan 18 18:04:40 UTC 2011


Avoid overwriting the real error message with a generic
OOM failure message, when machine type probe fails

* src/qemu/qemu_driver.c: Don't overwrite error
---
 src/qemu/qemu_driver.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index a1b9d2a..90429e5 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -6322,10 +6322,8 @@ qemudCanonicalizeMachineDirect(virDomainDefPtr def, char **canonical)
     virCapsGuestMachinePtr *machines = NULL;
     int i, nmachines = 0;
 
-    if (qemuCapsProbeMachineTypes(def->emulator, &machines, &nmachines) < 0) {
-        virReportOOMError();
+    if (qemuCapsProbeMachineTypes(def->emulator, &machines, &nmachines) < 0)
         return -1;
-    }
 
     for (i = 0; i < nmachines; i++) {
         if (!machines[i]->canonical)
-- 
1.7.3.4




More information about the libvir-list mailing list