[libvirt] [PATCH] qemu: don't fail capabilities check on 0.12.x
Eric Blake
eblake at redhat.com
Tue Jan 18 21:54:41 UTC 2011
On 01/18/2011 02:00 PM, Matthias Bolte wrote:
> 2011/1/18 Eric Blake <eblake at redhat.com>:
>> Fixes regression introduced in commit 2211518, where all qemu 0.12.x
>> fails to start, as does qemu 0.13.x lacking the pci-assign device.
>>
>> * src/qemu/qemu_capabilities.c (qemuCapsExtractVersionInfo): Check
>> for -device driver,? support.
>> (qemuCapsExtractDeviceStr): Avoid failure if all probed devices
>> are unsupported.
>> Reported by Ken Congyang.
>> ---
>
> ACK.
Thanks; pushed. I expanded the commit message a bit for clarity:
Fixes regression introduced in commit 2211518, where all qemu 0.12.x
fails to start, as does qemu 0.13.x lacking the pci-assign device.
Prior to 2211518, the code was just ignoring a non-zero exit status
from the qemu child, but the virCommand code checked this to avoid
masking any other issues, which means the real bug of provoking
non-zero exit status has been latent for a longer time.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110118/053958ec/attachment-0001.sig>
More information about the libvir-list
mailing list