[libvirt] [PATCH 0/2] make syntax-check detect raw close

Eric Blake eblake at redhat.com
Fri Jan 28 22:06:08 UTC 2011


As reported here, 'make syntax-check' missed a case:
https://www.redhat.com/archives/libvir-list/2011-January/msg01165.html

This cleans up the remaining offenders, then improves the rules.

Eric Blake (2):
  build: avoid close, system
  maint: reject raw close, popen in 'make syntax-check'

 .x-sc_prohibit_close         |    6 ++++
 .x-sc_prohibit_fork_wrappers |    8 +++++
 Makefile.am                  |    1 +
 cfg.mk                       |    9 +++++-
 src/datatypes.c              |    2 +-
 src/fdstream.c               |    6 ++--
 src/util/files.h             |    4 +-
 tests/commandtest.c          |   12 +++++---
 tools/virsh.c                |   59 +++++++++++++++++++----------------------
 9 files changed, 64 insertions(+), 43 deletions(-)
 create mode 100644 .x-sc_prohibit_fork_wrappers

-- 
1.7.3.5




More information about the libvir-list mailing list