[libvirt] [PATCHv2] build: consistently use CFLAGS

Eric Blake eblake at redhat.com
Fri Jul 1 16:48:53 UTC 2011


On 06/30/2011 05:51 PM, Laine Stump wrote:
>>> ACK.
>>
>> I spoke too soon - this patch causes /usr/include/libxml2 to be lost
>> from the include path, which breaks the build.
> 
> Okay, I found the problem. ACK with the following patch squashed in. (I
> checked all the other ..._CFLAGS in this particular Makefile and this
> was the only one missing AM_CFLAGS.

Actually, several footest_CFLAGS in tests/Makefile.am were also missing
AM_CFLAGS.

> 
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 2b6d0fb..4250f60 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -639,7 +639,7 @@ noinst_LTLIBRARIES += libvirt_driver_vmware.la
>  libvirt_la_BUILT_LIBADD += libvirt_driver_vmware.la
>  endif
>  libvirt_driver_vmware_la_CFLAGS = \
> -               -I at top_srcdir@/src/conf -I at top_srcdir@/src/vmx
> +               -I at top_srcdir@/src/conf -I at top_srcdir@/src/vmx $(AM_CFLAGS)

Thanks; squashed in and pushed.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110701/b688490c/attachment-0001.sig>


More information about the libvir-list mailing list