[libvirt] [PATCH] Fix compilation of statstest.c during make check

Eric Blake eblake at redhat.com
Thu Jul 7 16:28:29 UTC 2011


On 07/07/2011 10:16 AM, Jim Fehlig wrote:
> ---
>  tests/statstest.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tests/statstest.c b/tests/statstest.c
> index d18bb0c..c989992 100644
> --- a/tests/statstest.c
> +++ b/tests/statstest.c
> @@ -17,7 +17,7 @@ static void testQuietError(void *userData ATTRIBUTE_UNUSED,
>  
>  static int testDevice(const char *path, int expect)
>  {
> -    int actual = xenLinuxDomainDeviceID(NULL, 1, path);
> +    int actual = xenLinuxDomainDeviceID(1, path);

ACK.

This was a regression introduced in commit 60d769a1, back in April.  So
why did we not detect it until now?  What is different about your test
environment that triggered compilation of this code while others (myself
included) have been happily unaware of its existence?

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110707/a9050cad/attachment-0001.sig>


More information about the libvir-list mailing list