[libvirt] [PATCH 4/5] Fix leak of remote driver if final 'CLOSE' RPC call fails
Eric Blake
eblake at redhat.com
Fri Jul 8 14:56:08 UTC 2011
On 07/08/2011 05:57 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
>
> When closing a remote connection we issue a (fairly pointless)
> 'CLOSE' RPC call to the daemon. If this fails we skip all the
> cleanup of private data, but the virConnectPtr object still
> gets released as normal. This causes a memory leak. Since the
> CLOSE RPC call is pretty pointless, just carry on freeing the
> remote driver if it fails.
>
> * src/remote/remote_driver.c: Ignore failure to issue CLOSE
> RPC call
> ---
> src/remote/remote_driver.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
ACK.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110708/ad11fc53/attachment-0001.sig>
More information about the libvir-list
mailing list