[libvirt] [PATCH] virsh: fix missing prompt message for 'snapshot-delete' command
Eric Blake
eblake at redhat.com
Wed Jul 13 17:30:30 UTC 2011
On 07/13/2011 06:51 AM, Osier Yang wrote:
> 于 2011年07月13日 16:36, Nan Zhang 写道:
>> Make the command 'virsh snapshot-delete' has the appropriate prompt
>> message when executing sucessful or failed.
>>
>> - if (virDomainSnapshotDelete(snapshot, flags)< 0)
>
> You can keep this line unchanged, and switch the prompt strings for
> failure and success. But it's fine, ACK
>
>> + if (virDomainSnapshotDelete(snapshot, flags) == 0) {
>> + vshPrint(ctl, _("Domain snapshot %s deleted\n"), name);
>> + } else {
>> + vshError(ctl, _("Failed to delete snapshot %s"), name);
>> goto cleanup;
>> + }
I didn't see any reason to reorder things. I added Nan to AUTHORS and
pushed; let me know if I need to adjust any spellings.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110713/27c25086/attachment-0001.sig>
More information about the libvir-list
mailing list