[libvirt] [PATCH 3/8] save: wire up trivial saveFlags implementations

Eric Blake eblake at redhat.com
Fri Jul 15 13:16:30 UTC 2011

On 07/14/2011 08:24 AM, Eric Blake wrote:
> For all hypervisors that support save, the new API now performs
> the same functions as the old.
> * src/libxl/libxl_driver.c (libxlDomainSave): Move guts...
> (libxlDomainSaveFlags): ...to new function.
> * src/test/test_driver.c (testDomainSave, testDomainSaveFlags):
> Likewise.
> * src/vbox/vbox_tmpl.c (vboxDomainSave, vboxDomainSaveFlags):
> Likewise.

VBox virDomainSave doesn't work (it doesn't honor the destination file
name), and worse has no counterpart virDomainRestore (making it
absolutely worthless!).  I will split this patch to instead remove
vbox's virDomainSave, instead of wrapping it.  Or maybe we'll change
vbox's save to instead serve as virDomainManagedSave.  But the end
result is that is should not be part of this patch.

Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110715/f6c3a0d3/attachment-0001.sig>

More information about the libvir-list mailing list