[libvirt] [PATCHv3 6/6] build: add syntax check for proper flags use

Eric Blake eblake at redhat.com
Fri Jul 15 22:39:03 UTC 2011

On 07/15/2011 09:52 AM, Matthias Bolte wrote:
> 2011/7/15 Eric Blake<eblake at redhat.com>:
>> Enforce the recent flags cleanups - we want to use 'unsigned int flags'
>> in any of our APIs (except where backwards compatibility is important,
>> in the public migration APIs), and that all flags are checked for
>> validity (except when there are stub functions that completely
>> ignore the flags argument).
>> There are a few minor tweaks done here to avoid false positives:
>> signed arguments passed to open() are renamed oflags, and flags
>> arguments that are legitimately ignored are renamed flags_unused.
> ACK.

I've pushed this now.  I'll post a v4 of patch 5/6, which picks up some 
additional places where libvirt.c is wrongly filtering flags.

Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

More information about the libvir-list mailing list