[libvirt] [PATCH] udev: Don't try to dump DMI on non-intel archs

Michal Privoznik mprivozn at redhat.com
Tue Jul 19 15:12:50 UTC 2011

On 19.07.2011 17:01, Eric Blake wrote:
> On 07/19/2011 08:52 AM, Michal Privoznik wrote:
>> DMI is Intel& Intel-compatible specific. Don't try to dump information
>> on non-compatible architectures, which results only in error message in
>> logs.
>> ---
>> NB: libsmbios is exclusively for x86_64 ia64 %{ix86}
>> src/node_device/node_device_udev.c | 5 +++++
>> 1 files changed, 5 insertions(+), 0 deletions(-)
> ACK.
> But do we also need to patch src/util/sysinfo.c, which makes callouts to
> dmidecode(1)? That is, if libsmbios is arch-specific, then I imagine
> that so is dmidecode, and do we gracefully handle dmidecode failures in
> that case?

You're right. dmidecode is arch-specific as well. Right now we just fail 
in running it. Is it enough or should that be enclosed in conditional 
compilation as well?


More information about the libvir-list mailing list