[libvirt] [PATCHv2 0/9] network: physical device abstraction aka 'virtual switch'

Laine Stump laine at laine.org
Wed Jul 20 06:21:50 UTC 2011

This series deprecates patches 04/10 - 10/10 of the previous series of
the same name, posted here:


This patch is in response to the following bug reports:

 https://bugzilla.redhat.com/show_bug.cgi?id=643947 (RHEL)
 https://bugzilla.redhat.com/show_bug.cgi?id=636106 (upstream)

The first 4 patches of the earlier series were reasonable cleanups in
their own right, and were ACKed, so I pushed them earlier. I
reorganized the remaining 6 patches accord to advice from Dan Berrange
and Eric Blake. Some notes about correlation between v1 and v2:

[PATCHv2 1/9] util: define MAX
   A new patch

[PATCHv2 2/9] conf: put virtPortProfile struct / functions in a common location
   Was 05/10 in v1: https://www.redhat.com/archives/libvir-list/2011-July/msg00154.html

[PATCHv2 3/9] conf: virDomainNetDef points to (rather than contains) virtPortProfile
   This was also part of 05/10 in v1. I separated it out to make review of pure code movement
   (in 2/9) easier.

[PATCHv2 4/9] conf: support abstracted interface info in domain interface XML
[PATCHv2 5/9] conf: support abstracted interface info in network XML
   These two were 06/10 and 07/10 in v1:


   However, they were split differently. In v1 it was split into RNG
   changes vs. parser changes with network and domain combined in each
   patch. In v2, I reorganized (based on Dan's advice) to have one
   patch containing all domain XML changes, from RNG up through
   parser, test cases, and documentation, and one patch for network
   XML changes.

[PATCHv2 6/9] network: separate Start/Shutdown functions for new network types
   This was patch 08/10 in v1:


   It is unchanged from the original.

[PATCHv2 7/9] qemu: use virDomainNetGetActual*() functions where appropriate
[PATCHv2 8/9] qemu: use virDomainNetGetActual*() in qemuDomainXMLToNative
   These two were patch 09/10 in v1:


   In v2, I just split out one piece of code that was more complicated
   than just replacing direct data references with helper functions,
   and modified the commit message to be more clear about the "NOP"
   nature of the change.

[PATCHv2 9/9] network: internal API functions to manage assignment of physdev to guest

   This was 10/10 in v1:


   The main modification here was to remove all of the #if
   WITH_NETWORK from qemu_*.c, and instead define static inline NOP
   functions for the functions I'd previously eliminated references to
   with #if WITH_NETWORK (in the case that libvirt is build
   --without-network). This works out very well, except that make
   syntax-check doesn't like ATTRIBUTE_UNUSED in the inline static
   functions (I think we should change syntax-check rather than going
   back to the old #if WITH_NETWORK).

Comments about other changes I've made *within* each patch are in the
responses to the original patches, as well as in the annotations to
the new patches.

More information about the libvir-list mailing list