[libvirt] [PATCH] rpc: Pass through DISPLAY so ssh can launch askpass
Daniel P. Berrange
berrange at redhat.com
Wed Jul 20 18:15:08 UTC 2011
On Wed, Jul 20, 2011 at 02:14:43PM -0400, Cole Robinson wrote:
> Though we prefer users to have SSH keys setup, virt-manager users still
> depend on remote SSH connections to launch a password dialog. This fixes
> launch ssh-askpass
>
> Fix suggested by danpb
> ---
> src/rpc/virnetsocket.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c
> index 4403fc4..6605aa3 100644
> --- a/src/rpc/virnetsocket.c
> +++ b/src/rpc/virnetsocket.c
> @@ -604,6 +604,7 @@ int virNetSocketNewConnectSSH(const char *nodename,
> virCommandAddEnvPassCommon(cmd);
> virCommandAddEnvPass(cmd, "SSH_AUTH_SOCK");
> virCommandAddEnvPass(cmd, "SSH_ASKPASS");
> + virCommandAddEnvPass(cmd, "DISPLAY");
> virCommandClearCaps(cmd);
>
> if (service)
ACK
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list