[libvirt] [PATCH] util: make interface.c functions consistently return < 0 on error

Eric Blake eblake at redhat.com
Fri Jul 22 04:22:33 UTC 2011

On 07/21/2011 10:03 PM, Laine Stump wrote:
> (This patch must be pushed before the "listenNetwork" patches can be
> pushed)
> All of the functions in util/interface.c were returning 0 on success,
> but some returned -1 on error, and some returned a positive value
> (usually the value of errno, but sometimes just 1). Libvirt's standard
> is to return<  0 on error (in the case of functions that need to
> return errno, -errno is returned.
> This patch modifies all functions in interface.c to consistently
> return<  0 on error, and makes changes to callers of those functions
> where necessary.

I looked through the source code, and think you got all of the callers 
correctly, as well as all of interface.c.  Hopefully I didn't miss anything.


Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

More information about the libvir-list mailing list