[libvirt] [PATCHv3 1/2] conf: add <listen> subelement to domain <graphics> element

[Eric Blake]

On 07/26/2011 08:50 AM, Laine Stump wrote:
>> I think it is a somewhat overkill to have 'autoport' be a setting
>> per-<listen> element. I can't imagine people want a fixed port
>> number on one IP addr, but a dynamic port number on another IP
>> addr. So we could just keep that on the top level element.
>
> Although I agree with you for config purposes, it looks to me like the
> real use of autoport is that in the live XML it allows differentiating
> between ports that were manually specified and those that were
> automatically allocated (really, that seems like its main purpose, since
> simply not giving a port also implies autoport). If we have only a
> single autoport attribute for all the listens, we'll have to put in
> extra code that makes sure if they specify port for one listen, they do
> it for all of them.

Is it that hard to add that additional validation?  Regardless of that 
answer, and whether this requires a v4, I'll go ahead and review v3 code 
as if we decide that autoport-per-<listen> is acceptable.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org