[libvirt] [PATCH] rpc: Fix memory leak in remoteDomainSet*Parameters functions

Eric Blake eblake at redhat.com
Wed Jul 27 19:34:36 UTC 2011


On 07/27/2011 01:18 PM, Matthias Bolte wrote:
> Add a new helper remoteFreeTypedParameters and teach the generator
> to add it to the cleanup section.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=725322
> ---
>   src/remote/remote_driver.c |   22 +++++++++++++++++-----
>   src/rpc/gendispatch.pl     |    5 +++++
>   2 files changed, 22 insertions(+), 5 deletions(-)

ACK.

>
> diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c
> index 0652e0d..e5bfa4b 100644
> --- a/src/remote/remote_driver.c
> +++ b/src/remote/remote_driver.c
> @@ -1208,6 +1208,22 @@ done:
>       return rv;
>   }
>
> +/* Helper to free typed parameters. */
> +static void
> +remoteFreeTypedParameters(remote_typed_param *args_params_val,
> +                          u_int args_params_len)

Not the typical one-arg free function, so it can't be listed in cfg.mk, 
but that's okay, since it's only used in one file.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list