[libvirt] [virt-tools-list] virt-manager/libvirt backwards compatibility problem?

Guido Günther agx at sigxcpu.org
Thu Jul 28 22:44:39 UTC 2011

Hi Eric,

On Wed, Jul 27, 2011 at 02:52:46PM -0600, Eric Blake wrote:
> Pasting from that URL gave awkward results below; can you address my
> comments below, then post a v2 as a proper patch against
> libvirt.git?

Thanks for the review! New version attached.


> I don't like this part.  It is not safe to pass %s as the pathname
> through an additional round of shell parsing, since if the pathname
> has anything that might be construed as shell metacharacters, the
> parse will be destroyed.  To some extent, that is already a
> pre-existing bug (slightly mitigated by the fact that 'path' is
> under libvirt's control, and should not be containing arbitrary
> characters unless you passed odd directory choices to ./configure).

Would it make sense to pass such names through something like
g_shell_quote in instead of looking for troublesome characters? This
could be done using virBufferQuotedString? I'll post a patch for review
 -- Guido
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Autodetect-if-the-remote-nc-command-supports-the-q-o.patch
Type: text/x-diff
Size: 4647 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110729/834cfb5e/attachment-0001.bin>

More information about the libvir-list mailing list