[libvirt] [PATCH] build: avoid non-portable shell in test setup

Eric Blake eblake at redhat.com
Fri Jul 29 17:52:03 UTC 2011

On 07/29/2011 10:07 AM, Matthias Bolte wrote:
> 2011/7/29 Eric Blake<eblake at redhat.com>:
>> POSIX states that 'a=1; a=2 b=$a command' has unspecified results
>> for the value of $b visible within command.  In particular, on
>> BSD, this resulted in PATH not picking up the in-test ssh.
>> * tests/Makefile.am (lv_abs_top_builddir): New macro.
>> (path_add, TESTS_ENVIRONMENT): Use it to avoid referring to an
>> environment variable set previously within the same command line.
>> Reported by Matthias Bolte.
>> ---
> ACK, this make gmake check pass completely on FreeBSD.


Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

More information about the libvir-list mailing list