[libvirt] [PATCH 1/8] Define a QEMU specific API to attach to a running QEMU process

Eric Blake eblake at redhat.com
Fri Jul 8 20:52:36 UTC 2011


On 07/04/2011 04:28 AM, Daniel P. Berrange wrote:
> Introduce a new API in libvirt-qemu.so
> 
>  virDomainPtr virDomainQemuAttach(virConnectPtr domain,
>                                   unsigned long long pid,

We already assert elsewhere in our code base that pid_t will always fit
in int.  For example, see _virDomainObj in domain_conf.h.  Passing a ull
here seems like it might be overkill.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110708/91b0fac0/attachment-0001.sig>


More information about the libvir-list mailing list