[libvirt] testsuite formatting bugs [was: [PATCH] Skip some xen tests if xend is not running]

Matthias Bolte matthias.bolte at googlemail.com
Fri Jul 8 23:28:50 UTC 2011


2011/7/8 Eric Blake <eblake at redhat.com>:
> On 07/07/2011 04:21 PM, Eric Blake wrote:
>> Oh, and our testsuite has a cosmetic bug.  After applying your patch, I
>> see this during 'make check':
>>
>> TEST: xencapstest
>>       ..........                               10  OK
>> PASS: xencapstest
>> SKIP: reconnect
>> TEST: statstest
>>        0   FAIL
>> SKIP: statstest
>>
>> Bonus points for fixing up that output to say SKIP instead of FAIL and
>> to align it correctly (but that can be a separate patch).
>
> As long as we're investigating formatting errors, this one is also annoying:
>
> TEST: virsh-all
>      ........................................ 40
>      ........................................ 80
>      ........................................ 120
>      ....................................... 159 OK
> PASS: virsh-all
>
> We're obviously getting the logic wrong when there are 0 or when
> tests%40 == 39.

Here are two patches for this, plus one to use EXIT_AM_SKIP more.

-- 
Matthias Bolte
http://photron.blogspot.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-tests-Fix-compressed-test-output-padding-logic.patch
Type: text/x-diff
Size: 1241 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110709/652cff78/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-tests-Add-the-logic-to-skip-the-statstest-to-the-rig.patch
Type: text/x-diff
Size: 1678 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110709/652cff78/attachment-0004.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-tests-Use-EXIT_AM_SKIP-instead-of-77-directly.patch
Type: text/x-diff
Size: 2204 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110709/652cff78/attachment-0005.bin>


More information about the libvir-list mailing list