[libvirt] [PATCH] virsh: fix missing prompt message for 'snapshot-delete' command
Osier Yang
jyang at redhat.com
Wed Jul 13 12:51:01 UTC 2011
于 2011年07月13日 16:36, Nan Zhang 写道:
> Make the command 'virsh snapshot-delete' has the appropriate prompt
> message when executing sucessful or failed.
> ---
> tools/virsh.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/tools/virsh.c b/tools/virsh.c
> index cd17f42..b7cea58 100644
> --- a/tools/virsh.c
> +++ b/tools/virsh.c
> @@ -11534,8 +11534,12 @@ cmdSnapshotDelete(vshControl *ctl, const vshCmd *cmd)
> if (snapshot == NULL)
> goto cleanup;
>
> - if (virDomainSnapshotDelete(snapshot, flags)< 0)
You can keep this line unchanged, and switch the prompt strings for
failure and success. But it's fine, ACK
> + if (virDomainSnapshotDelete(snapshot, flags) == 0) {
> + vshPrint(ctl, _("Domain snapshot %s deleted\n"), name);
> + } else {
> + vshError(ctl, _("Failed to delete snapshot %s"), name);
> goto cleanup;
> + }
>
> ret = true;
>
More information about the libvir-list
mailing list