[libvirt] [PATCH 2/5] hyperv: Add driver skeleton

Matthias Bolte matthias.bolte at googlemail.com
Thu Jul 14 12:06:05 UTC 2011


2011/7/13 Eric Blake <eblake at redhat.com>:
> On 07/13/2011 01:01 PM, Matthias Bolte wrote:
>> ---
>>  cfg.mk                               |    1 +
>>  include/libvirt/virterror.h          |    1 +
>>  libvirt.spec.in                      |    9 +++

>> +++ b/src/hyperv/hyperv_driver.h
>> @@ -0,0 +1,29 @@
>> +
>> +/*
>> + * hyperv_driver.h: core driver functions for managing Microsoft Hyper-V hosts
>> + *
>> + * Copyright (C) 2011 Matthias Bolte <matthias.bolte at googlemail.com>
>> + * Copyright (C) 2009 Michael Sievers <msievers83 at googlemail.com>
>
> How much of this file is really attributable to Michael, vs. this just
> being copy and paste?
>
> ACK with the copyright nit fixed.

hyperv_driver.h comes directly from his original codebase. I just
changed indentation of the define to make cppi happy, so my copyright
notice is more debatable here than his. In contrast the other
secondary drivers were added by me to avoid libvirt trying to connect
to a non-existing libvirtd on the Hyper-V server (just the same reason
the ESX driver comes with stubs for all secondary drivers). Therefore,
I think there is nothing to be fixed on the copyright notice here.

Here's a v2 without the libvirt.spec.in part to match the v2 of 1/5.

-- 
Matthias Bolte
http://photron.blogspot.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-hyperv-Add-driver-skeleton_v2.patch
Type: text/x-patch
Size: 34846 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110714/864c2e93/attachment-0001.bin>


More information about the libvir-list mailing list