[libvirt] [PATCHv3 0/6] flags cleanup conclusion

Eric Blake eblake at redhat.com
Thu Jul 14 22:42:00 UTC 2011


With this, I think I've addressed all the review comments from v2:
https://www.redhat.com/archives/libvir-list/2011-July/msg00460.html

as well as a side discussion on public API flag filtering:
https://www.redhat.com/archives/libvir-list/2011-July/msg00833.html

Eric Blake (6):
  flags: use common dumpxml flags check
  flags: simplify qemu migration flags
  esx: reject unknown flags
  xen: reject unknown flags
  libvirt: do not mix internal flags into public API
  build: add syntax check for proper flags use

 cfg.mk                         |   30 ++++++++++--
 src/conf/domain_conf.c         |   25 +++++++--
 src/conf/domain_conf.h         |   10 ----
 src/driver.c                   |    4 --
 src/driver.h                   |   13 ++---
 src/esx/esx_device_monitor.c   |    4 +-
 src/esx/esx_driver.c           |   35 ++++++++++---
 src/esx/esx_interface_driver.c |    4 +-
 src/esx/esx_network_driver.c   |    4 +-
 src/esx/esx_nwfilter_driver.c  |    4 +-
 src/esx/esx_secret_driver.c    |    4 +-
 src/esx/esx_storage_driver.c   |    4 +-
 src/fdstream.c                 |   28 +++++-----
 src/fdstream.h                 |    6 +-
 src/libvirt.c                  |    6 +--
 src/libxl/libxl_driver.c       |    2 +
 src/locking/lock_driver_nop.c  |   10 ++--
 src/locking/lock_manager.c     |    7 ++-
 src/lxc/lxc_driver.c           |    2 +
 src/openvz/openvz_driver.c     |    2 +
 src/phyp/phyp_driver.c         |    2 +
 src/qemu/qemu_driver.c         |  107 +++++++++-------------------------------
 src/qemu/qemu_process.c        |    2 +-
 src/remote/remote_driver.c     |    8 +++-
 src/secret/secret_driver.c     |    7 ++-
 src/storage/storage_driver.c   |    2 +-
 src/test/test_driver.c         |    2 +
 src/uml/uml_driver.c           |   24 ++++++---
 src/util/command.c             |    2 +-
 src/util/iohelper.c            |   18 +++---
 src/util/util.c                |   14 +++---
 src/vbox/vbox_tmpl.c           |   18 +++++--
 src/vmware/vmware_driver.c     |    2 +
 src/xen/xen_driver.c           |   18 ++++++-
 src/xen/xen_driver.h           |    7 +++
 src/xen/xen_hypervisor.c       |    8 ++-
 src/xen/xen_inotify.c          |    4 +-
 src/xen/xend_internal.c        |   42 +++++++++++++---
 src/xen/xend_internal.h        |    3 +-
 src/xen/xm_internal.c          |   33 ++++++++++---
 src/xen/xm_internal.h          |    2 +-
 src/xen/xs_internal.c          |   12 +++-
 src/xenapi/xenapi_driver.c     |    4 +-
 43 files changed, 323 insertions(+), 222 deletions(-)

-- 
1.7.4.4




More information about the libvir-list mailing list