[libvirt] [RFC PATCH] qemu: Fail APIs not allowed during async job
Daniel P. Berrange
berrange at redhat.com
Fri Jul 15 15:18:54 UTC 2011
On Fri, Jul 15, 2011 at 04:41:38PM +0200, Jiri Denemark wrote:
> When an asynchronous job is running while another API that is
> incompatible with that job is called, we now try to wait until the job
> finishes and either run the API or fail with timeout. I guess nicer
> solution is to just fail such API immediately and let the application
> retry once the asynchronous job ends.
I'm not entirely convinced this is a good idea, because IIUC, what this
is in effect doing is having a zero second timeout. Previously we would
wait forever, currently we wait upto 30 seconds IIRC, and now we'll
wait 0 seconds. I think this will create lots of spurious timeouts
for applications to needlessly deal with.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list