[libvirt] [PATCH v3 5/8] undefine: Implement internal API for libxl driver

Eric Blake eblake at redhat.com
Mon Jul 18 18:43:46 UTC 2011


On 07/18/2011 01:53 AM, Osier Yang wrote:
> This is just similiar as changes on qemu driver.
>
> * src/libxl/libxl_driver.c: New callback for libxl_driver,
> new function libxlDomainUndefineFlags, and changes libxlDomainUndefine
> as a wrapper of libxlDomainUndefineFlags.
> ---
>   src/libxl/libxl_driver.c |   34 +++++++++++++++++++++++++++++++++-
>   1 files changed, 33 insertions(+), 1 deletions(-)

ACK.

> +    char *name = NULL;
>       int ret = -1;
>
> +    virCheckFlags(VIR_DOMAIN_UNDEFINE_MANAGED_SAVE, -1);

Oh, here you went with MANAGED_SAVE, instead of MANAGED_STATE in patch 
4/8 v3.  Double check that each patch in your series compiles cleanly 
before pushing.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list