[libvirt] [PATCH 4/4] Add an explicit virNetClientClose method

[Eric Blake]

On 07/19/2011 07:22 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange"<berrange at redhat.com>
>
> Since the I/O callback registered against virNetSocket will
> hold a reference on the virNetClient, we can't rely on the
> virNetClientFree to be able to close the network connection.
> The last reference will only go away when the event callback
> fires (likely due to EOF from the server).
>
> This is sub-optimal and can potentially cause a leak of the
> virNetClient object if the server were to not explicitly
> close the socket itself
>
> * src/remote/remote_driver.c: Explicitly close the client
>    object when disconnecting
> * src/rpc/virnetclient.c, src/rpc/virnetclient.h: Add a
>    virNetClientClose method
> ---
>   src/remote/remote_driver.c |    2 ++
>   src/rpc/virnetclient.c     |   22 +++++++++++++++++++++-
>   src/rpc/virnetclient.h     |    1 +
>   3 files changed, 24 insertions(+), 1 deletions(-)
>

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org