[libvirt] [PATCHv2 7/9] qemu: use virDomainNetGetActual*() functions where appropriate

Eric Blake eblake at redhat.com
Wed Jul 20 23:18:37 UTC 2011


On 07/20/2011 12:21 AM, Laine Stump wrote:
> The qemu driver accesses fields in the virDomainNetDef directly, but
> with the advent of the virDomainActualNetDef, some pieces of
> information may be found in a different place (the ActualNetDef) if
> the network connection is of type='network' and that network is of
> forward type='bridge|private|vepa|passthrough'. The previous patch
> added functions to mask this difference from callers - they hide the
> decision making process and just pick the value from the proper place.
>
> This patch uses those functions in the qemu driver as a first step in
> making qemu work with the new network types. At this point, the the
> virDomainActualNetDef is always NULL, so the GetActualX() function
> will return exactly what the def->X that's being replaced would have
> returned (ie bisecting is not compromised).

Indeed nicer wording.

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org




More information about the libvir-list mailing list