[libvirt] [PATCH 5/5] block_resize: Expose the new API to virsh

Osier Yang jyang at redhat.com
Tue Jul 26 05:51:12 UTC 2011


The units for "size" is kilobytes, "path" is the absolute path
of the disk image, which can be extract from the disk XML. E.g.
(<disk><source file='$path'/><disk>).
---
 tools/virsh.c   |   61 ++++++++++++++++++++++++++++++++++++++++++++++++++++++-
 tools/virsh.pod |    8 +++++++
 2 files changed, 68 insertions(+), 1 deletions(-)

diff --git a/tools/virsh.c b/tools/virsh.c
index 21c3124..02719fb 100644
--- a/tools/virsh.c
+++ b/tools/virsh.c
@@ -5229,6 +5229,64 @@ cmdBlockPull(vshControl *ctl, const vshCmd *cmd)
 }
 
 /*
+ * "blockresize" command
+ */
+static const vshCmdInfo info_block_resize[] = {
+    {"help", N_("Resize block device of domain.")},
+    {"desc", N_("Resize block device of domain.")},
+    {NULL, NULL}
+};
+
+static const vshCmdOptDef opts_block_resize[] = {
+    {"domain", VSH_OT_DATA, VSH_OFLAG_REQ, N_("domain name, id or uuid")},
+    {"path", VSH_OT_DATA, VSH_OFLAG_REQ, N_("Fully-qualified path of block device")},
+    {"size", VSH_OT_INT, VSH_OFLAG_REQ, N_("New size of the block device in kilobytes, "
+                                           "the size must be integer")},
+    {NULL, 0, 0, NULL}
+};
+
+static bool
+cmdBlockResize(vshControl *ctl, const vshCmd *cmd)
+{
+    virDomainPtr dom;
+    const char *path = NULL;
+    unsigned long long size = 0;
+    unsigned int flags = 0;
+    int ret = false;
+
+    if (!vshConnectionUsability(ctl, ctl->conn))
+        return false;
+
+    if (vshCommandOptString(cmd, "path", (const char **) &path) < 0) {
+        vshError(ctl, "%s", _("Path must not be empty"));
+        return false;
+    }
+
+    if (vshCommandOptULongLong(cmd, "size", &size) < 0) {
+        vshError(ctl, "%s", _("Unable to parse integer"));
+        return false;
+    }
+
+    if (size > ULLONG_MAX / 1024) {
+        vshError(ctl, _("Size must be less than %llu"), ULLONG_MAX / 1024);
+        return false;
+    }
+
+    if (!(dom = vshCommandOptDomain(ctl, cmd, NULL)))
+        return false;
+
+    if (virDomainBlockResize(dom, path, size, flags) < 0) {
+        vshError(ctl, _("Failed to resize block device '%s'"), path);
+    } else {
+        vshPrint(ctl, _("Block device '%s' is resized"), path);
+        ret = true;
+    }
+
+    virDomainFree(dom);
+    return ret;
+}
+
+/*
  * "blockjobinfo" command
  */
 static const vshCmdInfo info_block_job[] = {
@@ -12434,8 +12492,9 @@ static const vshCmdDef domManagementCmds[] = {
      info_attach_interface, 0},
     {"autostart", cmdAutostart, opts_autostart, info_autostart, 0},
     {"blkiotune", cmdBlkiotune, opts_blkiotune, info_blkiotune, 0},
-    {"blockpull", cmdBlockPull, opts_block_pull, info_block_pull, 0},
     {"blockjob", cmdBlockJob, opts_block_job, info_block_job, 0},
+    {"blockpull", cmdBlockPull, opts_block_pull, info_block_pull, 0},
+    {"blockresize", cmdBlockResize, opts_block_resize, info_block_resize, 0},
 #ifndef WIN32
     {"console", cmdConsole, opts_console, info_console, 0},
 #endif
diff --git a/tools/virsh.pod b/tools/virsh.pod
index 93ae50a..9aebca7 100644
--- a/tools/virsh.pod
+++ b/tools/virsh.pod
@@ -414,6 +414,14 @@ the B<shutdown> command instead.  However, this does not delete any
 storage volumes used by the guest, and if the domain is persistent, it
 can be restarted later.
 
+=item B<blockresize> I<domain> I<--path> I<--size>
+
+Resize a block device of domain while the domain is running, I<--path>
+specifies the absolute path of the block device, I<--size> specifies the
+new size in kilobytes
+
+The I<--managed-save> flag guarantees that any managed save image(see
+
 =item B<domblkstat> I<domain> I<block-device>
 
 Get device block stats for a running domain.
-- 
1.7.6




More information about the libvir-list mailing list