[libvirt] [PATCH] Fix error reporting with virDomainBlockStats on inactive guest

Eric Blake eblake at redhat.com
Thu Jun 2 14:26:50 UTC 2011


On 06/02/2011 07:58 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange at redhat.com>
> 
> Pull the check on virDomainIsActive upto top of the QEMU

s/upto/up to/

> impl of virDomainBlockStats so that is is reported promptly
> 
> * src/qemu/qemu_driver.c: Check if guest is active immediately
> ---
>  src/qemu/qemu_driver.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)

This means that we are now checking multiple times (once on entry for
immediate effect even if migration is under way, and again after
acquiring job condition if migration is not under way), but that
shouldn't hurt.

However, you also need to do the same thing for qemuDomainGetBlockInfo,
since both methods were given the same control flow during commit 18c2a592.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110602/e3ef2f3f/attachment-0001.sig>


More information about the libvir-list mailing list