[libvirt] [PATCH 1/7] lxc: Drop container stdio as late as possible
Eric Blake
eblake at redhat.com
Thu Jun 2 20:03:41 UTC 2011
On 06/02/2011 01:40 PM, Cole Robinson wrote:
> Makes it more likely we get useful error output in the logs
>
> Signed-off-by: Cole Robinson <crobinso at redhat.com>
> ---
> src/lxc/lxc_container.c | 29 ++++++++++++++++-------------
> 1 files changed, 16 insertions(+), 13 deletions(-)
ACK; however, this series is late enough that it should wait until after
the 0.9.2 release.
> @@ -806,17 +798,28 @@ static int lxcContainerChild( void *data )
>
> /* rename and enable interfaces */
> if (lxcContainerRenameAndEnableInterfaces(argv->nveths,
> - argv->veths) < 0)
> + argv->veths) < 0) {
> goto cleanup;
> + }
This particular change doesn't hurt or help; but I'm okay with leaving
it in from the consistency standpoint of using {} everywhere.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110602/e1ee5f87/attachment-0001.sig>
More information about the libvir-list
mailing list