[libvirt] [PATCH 00/10] coverity cleanups, round 1

Eric Blake eblake at redhat.com
Thu Jun 2 23:07:52 UTC 2011


Coverity reported a number of bugs against libvirt.  I ran out
of time to get through them all today, but there are certainly
some real doozies in here.  I've blamed commits where non-trivial
bugs were introduced, to help distros decide if things need
back-porting (I think that leaks on OOM situations and coverity
false positives are not serious enough to warrant a back-port).

These patches are pretty much independent (can be applied in any
order); I suppose I could have rebased it to order the series by
severity, oh well.

Eric Blake (10):
  command: avoid leak on failure
  libvirtd: avoid leak on failure
  storage: avoid memory leak
  storage: avoid memory leak on stat failure
  lock: avoid leak on failure
  remote: avoid leak on failure
  qemu: avoid memory leak on vcpupin
  event: avoid memory leak on cleanup
  build: silence coverity false positive
  build: silence coverity false positive

 daemon/libvirtd.c                |    4 +++-
 daemon/remote.c                  |    1 +
 src/conf/domain_event.c          |    3 ++-
 src/locking/lock_manager.c       |    3 ++-
 src/qemu/qemu_process.c          |   21 +++++++++++++--------
 src/remote/remote_driver.c       |    7 ++++++-
 src/storage/storage_backend_fs.c |   15 +--------------
 src/util/command.c               |    5 ++++-
 src/util/storage_file.c          |   15 +++++++--------
 9 files changed, 39 insertions(+), 35 deletions(-)

-- 
1.7.4.4




More information about the libvir-list mailing list