[libvirt] [libvirt-php][PATCH] screenshot of remote host is available

[Michal Novotny]

On 06/08/2011 05:13 AM, Daniel Veillard wrote:
>   Hi Yukihiro,
>
>
> On Thu, Jun 02, 2011 at 06:26:27AM +0000, warp.kawada at gmail.com wrote:
>> screenshot of remote host is available.
>> get_domain_object make so many error to message log, so you had
>> better not use .
>   I must admit I don't fully understand the problem you are having,
> do you mean that when trying to use the PHP binding for the new
> API to get the screenshots you were having errors ? What kind of
> errors and could you describe the context a bit, it will help
> understanding the issue and verifying your patch,
>
>   Michal could you have a look ?  Seems the patch changes the way to
> lookup the domain, and tries to provide non-local access but I'm
> not 100% sure,
>

Sure, Daniel. I've been looking to this and I don't really follow what
Yukihiro meant. Could you provide me more information on the error
you're experiencing and also append the gcc version and PHP version? I
didn't run into those issues on php-5.3.6-1.fc14.i686
and gcc-4.5.1-4.fc14.i686.

Yukihiro, why did you change the get_domain_object() to lookup by UUID
string and get the domain screenshot with using the second argument you
introduced? This is concept is OK for getting the remote host screenshot
however I don't really follow the lines about get_domain_object(). Could
you please explain?

Thanks,
Michal


-- 
Michal Novotny <minovotn at redhat.com>, RHCE
Virtualization Team (xen userspace), Red Hat