[libvirt] FreeBSD Port, update to 0.9.2 compile error

[Jason Helfman]

> On Tue, Jun 07, 2011 at 11:08:02PM -0700, Jason Helfman wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA256
>>
>> On Tue, Jun 07, 2011 at 09:45:41PM -0600, Eric Blake thus spake:
>> >On 06/07/2011 09:27 PM, Jason Helfman wrote:
>> >> Hi,
>> >>
>> >> I am trying to update the port for libvirt to 0.9.2, but am receiving
>> a new
>> >> compiling error, that I have not seen yet.
>> >
>> >Is this a VPATH build?
>> >
>> >> `/home/jhelfman/ports/devel/libvirt/work/libvirt-0.9.2/docs'
>> >>   GEN    libvirt-api.xml
>> >> ./apibuild.py: not found
>> >
>> >What does 'gmake V=1' show for the full command being attempted here?
>> >
>> >> Any thoughts?
>> >
>> >Possibly a missing make dependency, or a VPATH problem.  I'll try to
>> >find some time to look into it tomorrow (it's late for me tonight).
>> >
>>
>> I found the issue in building was an absolute path for apibuild.py for
>> python, that is incorrect on FreeBSD.
>
>  okay, where is it on FreeBSD ?

/usr/local/bin

>
>> Here is a patch:
>>
>> - --- ./docs/apibuild.py.orig	2011-06-07 21:31:43.000000000 -0700
>> +++ ./docs/apibuild.py	2011-06-07 21:31:55.000000000 -0700
>> @@ -1,4 +1,4 @@
>> - -#!/usr/bin/python -u
>> +#!/usr/bin/env python
>
>   I have seens people complaining loudly because env was used like this
> for example:
>
> http://forums.westhost.com/showthread.php?9984-usr-bin-env-python-doesn-t-work

I would argue that using /usr/bin/env is the correct way to handle this
and users that this breaks for haven't properly configured their
environment path for their binaries. Non-standard paths should be put in a
path so /usr/bin/env will work. /usr/bin and /usr/local/bin are very
standard, in my humble opinion.

>
>   another way would be to launch python directly giving the path to the
> python script, this is likely to solve the issue there.
>
> Daniel
>
> --
> Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
> daniel at veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
> http://veillard.com/ | virtualization library  http://libvirt.org/
>
>
-Jason