[libvirt] [PATCH v4]: set and restore MAC address of a NIC when using PASSTHROUGH mode

[Stefan Berger]

On 06/21/2011 01:16 PM, Eric Blake wrote:
> On 06/21/2011 06:01 AM, Gerhard Stenzel wrote:
>> +    rc = ifaceGetMacaddr(linkdev, oldmac);
>> +
>> +    if (rc) {
>> +        virReportSystemError(rc,
> Sorry for not catching this sooner.  This should probably be
> virReportSystemError(errno,...), assuming that ifaceGetMacaddr
> guarantees a sane errno setting (at any rate, you used errno for
> ifaceSetMacaddr later on).
>
It should be ok the way it is since ifaceGetMacAddr() returns either 
EINVAL or the content of errno.

    Stefan
>
>
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110621/3877c957/attachment-0001.htm>