[libvirt] [PATCH 2/2 V2] cleanup: make several interface functions commonly available

Stefan Berger stefanb at linux.vnet.ibm.com
Wed Jun 22 19:01:26 UTC 2011


On 06/22/2011 01:32 PM, Eric Blake wrote:
> On 06/21/2011 06:05 PM, Stefan Berger wrote:
>> In a second cleanup step this patch makes several interface functions
>> from macvtap.c commonly available by moving them into interface.c and
>> prefixing their names with 'iface'.
>>
>> ifaceRestoreMacAddress returns the return code from the
>> ifaceSetMacAddres call and display an error message if setting the MAC
>> address did not work. The caller is unchanged and still ignores the
>> return code (which is ok).
>>
>> This patch also fixes a problem with the return code of
>> ifaceSetMacAddress being used for error reporting in one place rather
>> than errno.
>>
>> v2:
>>   - making all functions visible on all platforms
>>
>> Signed-off-by: Stefan Berger<stefanb at linux.vnet.ibm.com>
>>
> ACK.  The libvirt_linux.syms suggestion was nice too, but now that
> you've already done the work to expose the symbols everywhere, it
> doesn't hurt to keep it that way.
>
Pushed both patches.

   Stefan




More information about the libvir-list mailing list